[2.x] New asset system #2006
Merged
[2.x] New asset system #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #2006 +/- ##
============================================
Coverage 100.00% 100.00%
- Complexity 1891 1939 +48
============================================
Files 194 196 +2
Lines 5044 5160 +116
============================================
+ Hits 5044 5160 +116 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
new-asset-system
branch
from
7151c17 to
e800ecf
Compare
This was referenced Nov 11, 2024
caendesilva
added
the
run-visual-tests
caendesilva
force-pushed
the
new-asset-system
branch
2 times, most recently
from
17f9df0 to
c07f27f
Compare
This was referenced Nov 14, 2024
caendesilva
removed
the
run-visual-tests
This was referenced Nov 16, 2024
caendesilva
force-pushed
the
new-asset-system
branch
2 times, most recently
from
d335c54 to
c2f76be
Compare
Co-Authored-By: StyleCI Bot <[email protected]>
caendesilva
force-pushed
the
new-asset-system
branch
from
394ed3a to
a037ab1
Compare
caendesilva
force-pushed
the
new-asset-system
branch
from
8b467ab to
6be9c9d
Compare
caendesilva
force-pushed
the
new-asset-system
branch
from
5e85a0c to
17fa356
Compare
In HydePHP v2 and HydeFront v4 there is only one file, so we no longer need this parameter as it will never be useful for anything else than `app.css`.
Was considering renaming it, but I could not really find a better method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This pull request for HydePHP v2 brings several improvements on how we handle assets in HydePHP. It brings a complete rewrite of the HydeFront asset handling system, replacing Laravel Mix with Vite, and favouring Blade-based components with Tailwind classes over CSS partials and custom stylesheets.
Introduces Vite
In these pull requests we replaced Laravel Mix with Vite:
--run-devand--run-prodbuild command flags with--run-viteflag #2013HydeFront v4
We are updating how HydeFront is handled for v2. Instead of declaring styles directly in HydeFront alongside Tailwind, we will refactor those styles into Tailwind.
HydeFront will serve two main purposes:
app.cssfile bundled with new apps, available through the HydeFront CDN.app.css, which we will preconfigure.For example, users can include our Tailwind styles granularly using just the
app.cssfile from the HydeFront package. This file will be compiled alongside Tailwind. If users prefer customization, they can remove the import and add the specific styles they want.hyde.cssfile from HydeFront #2037Related Changes